Is there a reason to reset the columns
last_logoutI don't realise?
Yes. The reason is, that these user will be delete in 30 days, i.e., (NOW - 3 YEAR - 30 days), cf. functions.inc.php#L183
Ahh, yes. That sounds reasonable.
I realise, that my review at the time of the implementation was not really profound. In that case I would have at least proposed, to store the information about a carried out notification in another way. Now my proposal was to store this information as a timestamp in an otherwise empty (
NULL) datetime-column. So we wouldn't need to manipulate a time information with a regulary different meaning. But that's, if at all, at the moment [s]not an urgent[/s] completely useless discussion. At the time of the pull request been open, it would have been appropriate.
Shit happens. 🤷
Trenne niemals Müll, denn er hat nur eine Silbe!