Hi,

Is this code sample called at posting time or at the time the post is displayed on the forum?

You are rigth. The code is called during the submission of the posting and not on displaying.

Or I could allow unregistered users to post images and simply allow the parsing to eat the disallowed tags, right?

Yes.

If this button change really is necessary

No, it is an optical part. The img-button becomes useless for unregistered users.

Can you at least list the source file and the identifier(s) near where I would do this?

Each pho file has its corresponding template file, e.g. posting.inc.tpl. In line 170ff, the bb-codes button are defined. Using a if-else condition, you can restrict displaying the button.

/Micha