MLF Responsive Question (Design/Themes)

by Joe I, Tuesday, May 23, 2023, 10:11 (565 days ago)

Hey guys,

We are currently running MLF on 2.4.24, and it is running great, but I really like the way this MLF forum here displays on mobile. I've updated a test version of our site to 20220803.1, but it doesn't look nearly as good as this site. Is there a step I'm missing after the upgrade related to templates or other to better mimic MLF here?


For clarity, the differences are in the way this site on mobile has Latest postings and Recent tags at the top of the page, but my 20220803.1 has both sitting on the right side of the page, identical to desktop.

Thanks, Joe

Avatar

MLF Responsive Question

by Auge ⌂, Wednesday, May 24, 2023, 05:16 (565 days ago) @ Joe I

Hello

Your request will not be forgotten. I'll respond in a few hours.

Tschö, Auge

--
Trenne niemals Müll, denn er hat nur eine Silbe!

Avatar

MLF Responsive Question

by Auge ⌂, Friday, May 26, 2023, 07:11 (563 days ago) @ Joe I

Hello

I'm sorry, it took much longer than expected to find time to answer.

We are currently running MLF on 2.4.24, and it is running great, but I really like the way this MLF forum here displays on mobile. I've updated a test version of our site to 20220803.1, but it doesn't look nearly as good as this site. Is there a step I'm missing after the upgrade related to templates or other to better mimic MLF here?

Generally there are no new ressources except the icon themes/default/images/keep_eye_on.png and themes/default/images/image.png:

[image] [image]

Everything else (that belongs to the theming part) are only changed files. So the first attempt should be to reupload all files of the theme (themes/default/), to remove the files from the sub directory templates_c and to reload the page from the server (on a desktop system with [CTRL]+[F5]). If that doesn't fix the problem, I would like to ask you for a link to the test system so I can look at it directly.

Tschö, Auge

--
Trenne niemals Müll, denn er hat nur eine Silbe!

Followup Help Needed

by Joe I, Thursday, August 08, 2024, 12:16 (123 days ago) @ Auge

Hey Auge,

I just performed a test update to 20240729.1 on our forum, including the latest ft.last_reply fix from today. All looks good, except I keep running into this nagging issue with Responsive display not working (On this forum, the latest postings show nicely above the thread list, but on the linked forum. they are side-by-side). I've gotten it to work somewhat randomly with previous update tests, but really can't figure out what step I'm missing with this one. I went back and performed all the file / folder upload, delete, refresh to no avail. This was a straight update from 2.4.24 to 20240729.1.

When you get a chance, can you look at this test site for me?: https://bluegraysky.com/forum-20240729/

Thanks so much, Joe

Avatar

Followup Help Needed

by Auge ⌂, Thursday, August 08, 2024, 07:04 (123 days ago) @ Joe I

Hello Joe

I just performed a test update to 20240729.1 on our forum, including the latest ft.last_reply fix from today. All looks good, except I keep running into this nagging issue with Responsive display not working (On this forum, the latest postings show nicely above the thread list, but on the linked forum. they are side-by-side). I've gotten it to work somewhat randomly with previous update tests, but really can't figure out what step I'm missing with this one. I went back and performed all the file / folder upload, delete, refresh to no avail. This was a straight update from 2.4.24 to 20240729.1.

When you get a chance, can you look at this test site for me?: https://bluegraysky.com/forum-20240729/

As far I can see, you applied your own changes to the CSS-file (or you use you own CSS in general) but you did not apply the changes in the CSS of the new version(s). That includes the media query part, starting with line #465 (version 20240729.1). There may be further code but that's, what is missed here.

Tschö, Auge

--
Trenne niemals Müll, denn er hat nur eine Silbe!

Avatar

Followup, recommendation: use a diff tool

by Auge ⌂, Thursday, August 08, 2024, 07:56 (123 days ago) @ Joe I

Hello Joe

I compared the files style.min.css of the project forum and your test installation in a diff tool. I used WinMerge for the comparision. As feared, there are far more differences between the rules. Some differences are due to your forum's own rules, but others are due to the lack of transfer from the newer versions.

I have also exported a diff file, but reading it is very confusing. I will therefore not include it here. Choose a diff tool yourself. I can recommend WinMerge for Windows and Meld for Linux. Better you compare the data by yourself because you know your requirements best.

Tschö, Auge

--
Trenne niemals Müll, denn er hat nur eine Silbe!

Thank you, that file is what I needed.

by Joe I, Friday, August 09, 2024, 01:14 (122 days ago) @ Auge

Let me do a little digging and I appreciate your help.

Auge, a quick note.

by Joe I, Thursday, September 12, 2024, 08:18 (88 days ago) @ Joe I
edited by Joe I, Thursday, September 12, 2024, 08:56

Before upgrading, I made a full copy of our forum and DB. I then performed the upgrade on the copied forum, and ran into the Style challenge mentioned above. I confirmed that the CSS and TPL files in that upgraded forum folder were copied correctly, and did not make any changes after the upgrade, but the old forum styles persisted.

The key to all this is actually the Admin / Forum Settings / Forum Address (URL) option. When I originally copied the forum, I did not make any adjustments within Settings, so Forum Address was still pointing to the (original) production forum, which had our existing style changes. And, as I found out, Style information is pulled from the URL specified in Forum Address, and does not use a relative path to the current forum folder. You're likely aware of all this, it just happened to be new info to me.

Joe

Avatar

Auge, a quick note.

by Auge ⌂, Friday, September 13, 2024, 12:21 (87 days ago) @ Joe I

Hello

Before upgrading, I made a full copy of our forum and DB. I then performed the upgrade on the copied forum, and ran into the Style challenge mentioned above. I confirmed that the CSS and TPL files in that upgraded forum folder were copied correctly, and did not make any changes after the upgrade, but the old forum styles persisted.

The key to all this is actually the Admin / Forum Settings / Forum Address (URL) option. When I originally copied the forum, I did not make any adjustments within Settings, so Forum Address was still pointing to the (original) production forum, which had our existing style changes. And, as I found out, Style information is pulled from the URL specified in Forum Address, and does not use a relative path to the current forum folder.

Yes, the link to the CSS-file is given as an absolute URL. I don't know, why Alex decided so, but this behaviour is really "old".

<link rel="stylesheet" type="text/css" href="https://mylittleforum.net/forum/themes/default/style.min.css" media="all" />

Generally it would be no problem to change this behaviour. In line #15 of the main template one can see, that the first part of the URL ({$FORUM_ADDRESS}/) can simply be removed.

<link rel="stylesheet" type="text/css" href="{$FORUM_ADDRESS}/{$THEMES_DIR}/{$theme}/style.min.css" media="all" />

This would result in a relative and functioning path.

<link rel="stylesheet" type="text/css" href="themes/default/style.min.css" media="all" />

As far as I know, the index.php, which is built from the main template, is the base for all pages with exception of the JS-popups, which has their own document-complete HTML-templates. So I expect this to work. But this will not prevent issues with the browser caching and the prerendered templates after an upgrade.

Tschö, Auge

--
Trenne niemals Müll, denn er hat nur eine Silbe!

Avatar

Auge, a quick note.

by Micha ⌂, Friday, September 13, 2024, 08:37 (87 days ago) @ Auge

Hello,

Yes, the link to the CSS-file is given as an absolute URL. I don't know, why Alex decided so, but this behaviour is really "old".

Afaik, it wasn't Alex. We changed all paths to absolut ones to avoid CSS injections.

/Micha

--
applied-geodesy.org - OpenSource Least-Squares Adjustment Software for Geodetic Sciences

Avatar

Auge, a quick note.

by Auge ⌂, Friday, September 13, 2024, 09:03 (87 days ago) @ Micha

Hello

Yes, the link to the CSS-file is given as an absolute URL. I don't know, why Alex decided so, but this behaviour is really "old".


Afaik, it wasn't Alex. We changed all paths to absolut ones to avoid CSS injections.

Thank you for the clarification. After (re)-learning this, the behaviour should remain unchanged.

Tschö, Auge

--
Trenne niemals Müll, denn er hat nur eine Silbe!

RSS Feed of thread