Hi,

I took a look to your forums. I notice a different HTML structure for the footer:

The old structure reads (taken from /forum/):

<div id="footer">
<div id="footer-1">51 Postings in 9 Threads, 3 registered users, 4 users online (0 registered, 4 guests)<br />
Forum time: 2020-10-02, 08:25 (UTC)</div>
<div id="footer-2">
<ul id="footermenu">
<li><a class="rss" href="index.php?mode=rss" title="RSS Feed of all new postings">RSS Postings</a> &nbsp;<a class="rss" href="index.php?mode=rss&amp;items=thread_starts" title="RSS Feed of thread starting postings only">RSS Threads</a></li></ul></div>
</div>

versus (the new one in /forum-2/)

<div id="footer">
<div id="footer-1">51 Postings in 9 Threads, 3 registered users, 4 users online (0 registered, 4 guests)<br />
Forum time: 2020-10-02, 08:26 (UTC)</div>
<div id="footer-2">
<ul id="footermenu">
 <li><a href="#top" class="go-to-top-link" title="Go back to top of the page">To top</a></li>
 <li><a class="rss" href="index.php?mode=rss" title="RSS Feed of all new postings">RSS Postings</a></li>
 <li><a class="rss" href="index.php?mode=rss&amp;items=thread_starts" title="RSS Feed of thread starting postings only">RSS Threads</a></li></ul>
</div>
</div>

Since the footer was re-structured by a list (Thanks to Auge for this semantic change!), the corresponding CSS must be adapted, too. There are several changes in CSS-file not only the role a.rss, cf. #530, #531, and #533.

Both forums include the same CSS file (because of using the global variable {$FORUM_ADDRESS}/{$THEMES_DIR}/{$theme} in template) but use different HTML structure for the footer.

/Micha

does your CSS files contain the rule p.right a.rss?

Yes, my CSS file(s?) https://www.rapideuphoria311.com/forum/themes/default/style.min.css contain the rule p.right a.rss in line #61:

p.right a.rss{padding-left:15px}
 

As I said: I've made a fresh install of mylittleforum-2.4.23.tar.gz, after deleting the previous forum/ directory, therefore ALL files must belong to 2.4.23 version.

If yes, includes the template the correct CSS file?

Micha, I don't know which template to check, do you mean:

https://www.rapideuphoria311.com/forum/themes/default/main.tpl

If yes, then this is line #14:

<link rel="stylesheet" type="text/css" href="{$FORUM_ADDRESS}/{$THEMES_DIR}/{$theme}/style.min.css" media="all" />
 

thank you, shian

Hello WorldofBB,

Micha:

The relevant code is here:

Thank you for providing this solution. I have added your code the repository #534.

Kind regards
Micha

shian:

As a workaround, you could change line 61 in style.min.css to this:

p.right a.rss,div.small a.rss{padding-left:15px}

Thank you very much WorldofBB,

I'll apply your code as soon as I finish to enter my 134-characters-length password to the server... (without mistakes...)

Thank you also for helping Micha.

All the best, shian.

Hello

I replied to this initially with a suggestion that it might be a local caching issue because I wasn't seeing the issue on your site at first. I deleted my initial reply when I realized my mistake.

The problem occurs only in thread view, and it affects this site as well.

I also didn't see the problem in shian's forum because of the use of the single-entry-view.

As a workaround, you could change line 61 in style.min.css to this:

p.right a.rss,div.small a.rss{padding-left:15px}

That should work fine …

It's good enough for an instantaneous fix.

… but I'm guessing the devs would want to do this a little differently since I'm noticing that there is some manual styling on these entries that should probably be converted to a css class at the same time.

I have to disagree (a little bit). Yes, a unification of the structure of the views is desirable. But you unified only the threaded view (nested view) with the flat threaded view (board view) but not with the single entry view, where the link is HTML-sided contained in a p (paragraph) and not in a div and where there is no inline styling.

For further details please compare entry.inc.tpl (line 68) with thread.inc.tpl (line 91) and with thread_linear.inc.tpl (line 87).

You are right, the inline styles should get replaced and this seems to be an easy task because entry.inc.tpl yet makes use of a proper class "right" (with a not so proper naming). It's debatable if a paragraph as the container is plausible or if the use of a div would be better but beside from that we should use the same HTML-structure in all three views. And when we do, we can use the same CSS-ruleset for all RSS-links in all views.

[edit-1]
Oh, not to forget. Thank you for your research and work.
[/edit-1]

[edit-2]
A doubled thank you. While doing my own research for comparision of the relevant code in the default theme and in my theme Responsive_1 I found similar structural differences in my own theme. There is some work waiting for me.
[/edit-2]

Tschö, Auge