Avatar

Seeing other user's spam posts (Bugs)

by Magma @, Thursday, September 05, 2019, 22:58 (73 days ago)

Not sure if this is normal behaviour or a bug? It seems like you should not be able to see other user's spam posts when logged in.

  • I posted a message that was flagged as spam (yellow box) to a thread that had many replies
  • I then clicked show postings in top menu
  • I then clicked the spam message I had just posted which takes me to the thread I had just posted to


The list of complete thread links at the bottom of the page then shows me all the other spam messages that other users have posted to that thread and I can even click on them and look at the spam post??

Avatar

Seeing other user's spam posts

by Micha ⌂, Friday, September 06, 2019, 07:45 (73 days ago) @ Magma

Hello,

It seems like you should not be able to see other user's spam posts when logged in.

This is the normal behavior of the software.

The list of complete thread links at the bottom of the page then shows me all the other spam messages that other users have posted to that thread and I can even click on them and look at the spam post??

I'm sorry, but, who like to read the SPAM of other users???

/Micha

--
applied-geodesy.org - OpenSource Least-Squares Adjustment Software for Geodetic Sciences

Avatar

Seeing other user's spam posts

by Magma @, Friday, September 06, 2019, 11:16 (73 days ago) @ Micha

I'm sorry, but, who like to read the SPAM of other users???

That's the problem, you do not know it's spam until you click on it. I thought the whole point of posts being flagged as spam was so that other users did not see these posts at all.

Avatar

Seeing other user's spam posts

by Auge ⌂ @, Friday, September 06, 2019, 12:19 (73 days ago) @ Magma

Tschö, Auge

I'm sorry, but, who like to read the SPAM of other users???


That's the problem, you do not know it's spam until you click on it. I thought the whole point of posts being flagged as spam was so that other users did not see these posts at all.

Nobody sees these postings with exception of moderators and admins who should be able to reflag the postings as ham or to delete them.

Tschö, Auge

--
Trenne niemals Müll, denn er hat nur eine Silbe!

Avatar

Seeing other user's spam posts

by Magma @, Friday, September 06, 2019, 21:36 (73 days ago) @ Auge

Maybe I didn't explain it very well.

I was logged in as a standard user and posted a message to an existing thread that had 10 replies (in single post mode not open thread) the yellow box came up saying it was possible spam and I could then scroll down the page to the complete thread: links and there was 15 links showing, 1 being my spam link and 4 others of which were spam from other users and I could click on one of these other 4 and read the spam message from that user (it was even showing the yellow box).

Does that explain any better?

Avatar

Seeing other user's spam posts

by Micha ⌂, Saturday, September 07, 2019, 09:44 (72 days ago) @ Magma

Hi,

Does that explain any better?

I think so, yes. I believe, the cause is this line. I'll provide a fix.

/Micha

--
applied-geodesy.org - OpenSource Least-Squares Adjustment Software for Geodetic Sciences

Avatar

Seeing other user's spam posts - Solved

by Micha ⌂, Saturday, September 07, 2019, 14:00 (72 days ago) @ Magma

Hi,

I added a fix to the 2.5 branch.

Thank you
Micha

--
applied-geodesy.org - OpenSource Least-Squares Adjustment Software for Geodetic Sciences

Avatar

Seeing other user's spam posts - Solved

by Magma @, Saturday, September 07, 2019, 15:29 (72 days ago) @ Micha

I'm still on 2.4.19, so I can replace the 3 lines of red code with 4 green in includes/entry.inc.php and that is the only file I need to edit for this problem?

Avatar

Seeing other user's spam posts - Solved

by Micha ⌂, Saturday, September 07, 2019, 15:42 (72 days ago) @ Magma

Hi,

please replace the two lines:

if ($entrydata['akismet_spam'] == 1 || $entrydata['b8_spam'] == 1)
 $display_spam_query_and = '';

by the changed lines:

if ($entrydata['spam'] == 1 && isset($id))
 $display_spam_query_and .= " OR `ft`.`id` = " . intval($id);

Let me know, if it does not work as expected.

/Micha

--
applied-geodesy.org - OpenSource Least-Squares Adjustment Software for Geodetic Sciences

Avatar

Seeing other user's spam posts - Solved

by Magma @, Saturday, September 07, 2019, 16:06 (72 days ago) @ Micha

Hi,

please replace the two lines:

if ($entrydata['akismet_spam'] == 1 || $entrydata['b8_spam'] == 1)
$display_spam_query_and = '';


I don't see the two lines exactly like that above, line 132-135 shows as

// thread-data:
 $thread = $entrydata['tid'];
 if ($entrydata['spam'] == 1)
  $display_spam_query_and = '';
Avatar

Seeing other user's spam posts - Solved

by Micha ⌂, Saturday, September 07, 2019, 16:15 (72 days ago) @ Magma

Hi,

I don't see the two lines exactly like that above, line 132-135 shows as

These are the original lines (see red lines in pull #509). Maybe, your file is not up to date...?!

if ($entrydata['spam'] == 1)
$display_spam_query_and = '';


Replace it by

if ($entrydata['spam'] == 1 && isset($id))
 $display_spam_query_and .= " OR `ft`.`id` = " . intval($id);

/Micha

--
applied-geodesy.org - OpenSource Least-Squares Adjustment Software for Geodetic Sciences

Avatar

Seeing other user's spam posts - Solved

by Magma @, Saturday, September 07, 2019, 19:29 (72 days ago) @ Micha

if ($entrydata['spam'] == 1)
$display_spam_query_and = '';

Replace it by

if ($entrydata['spam'] == 1 && isset($id))
$display_spam_query_and .= " OR `ft`.`id` = " . intval($id);


I will just replace these then

Thanks

Avatar

Seeing other user's spam posts - Solved

by Micha ⌂, Sunday, September 08, 2019, 18:51 (71 days ago) @ Magma

Hi,

I will just replace these then

Perfect!

/Micha

--
applied-geodesy.org - OpenSource Least-Squares Adjustment Software for Geodetic Sciences

Avatar

Seeing other user's spam posts - Solved

by Magma @, Saturday, September 07, 2019, 16:22 (72 days ago) @ Micha

if ($entrydata['akismet_spam'] == 1 || $entrydata['b8_spam'] == 1)

I did just download 2.4.20 to compare the includes/entry.inc.php file and I couldn't find this line in there either.

Avatar

Seeing other user's spam posts - Solved

by Micha ⌂, Saturday, September 07, 2019, 17:16 (72 days ago) @ Magma

Hi,

I did just download 2.4.20 to compare the includes/entry.inc.php file and I couldn't find this line in there either.

The line was added in #427 (19 Dec 2018) - see file history. It is part of the version 2.4.99.1.

/Micha

--
applied-geodesy.org - OpenSource Least-Squares Adjustment Software for Geodetic Sciences

RSS Feed of thread
powered by my little forum