Avatar

Version 2.4.18 - Scaling Images when clicking on preview (General)

by Magma, Thursday, January 17, 2019, 15:07 (98 days ago)

I'm pretty sure with 2.4.8 Images in the preview pane were scaled down properly

If you click on the preview speech bubble Icon of a post where an Image has been posted, the Image in the yellow preview box has not been scaled down properly, it squishes the Image unlike in 2.4.8 where I'm sure it scaled the Image down to the right size

If you preview this post you will see

[image]

Avatar

Version 2.4.18 - Scaling Images when clicking on preview

by Auge ⌂ @, Thursday, January 17, 2019, 15:30 (98 days ago) @ Magma

hello

I'm pretty sure with 2.4.8 Images in the preview pane were scaled down properly

I'm not sure but I don't know when we touched the code for the last time.

If you click on the preview speech bubble Icon of a post where an Image has been posted, the Image in the yellow preview box has not been scaled down properly, it squishes the Image unlike in 2.4.8 where I'm sure it scaled the Image down to the right size

Generally it's the same solution like that for your thumbnail issue. I have to search for the correct CSS-selector and will publish a fix soonish. Because this is a cosmetical issue, I will not create a new release with this fix only. You will have to insert it tentatively into your live code yourself, when the fix is ready.

Tschö, Auge

--
Trenne niemals Müll, denn er hat nur eine Silbe!

Avatar

Version 2.4.18 - Scaling Images in preview, solved

by Auge ⌂ @, Friday, January 18, 2019, 13:36 (97 days ago) @ Magma

Hello

I fixed it in this forum but did not create a commit and PR until now. Check your own example, a reload from the server might be necessary (push [CTRL]+[F5]). Change the following code.

style.css, line #659 (optional [1]):

/* from */
#ajax-preview-content img { max-width: 100%; }
/* to */
#ajax-preview-content img { max-width: 100%; height: auto; }

style.min.css, line #436 (mandatory [1]):

/* from */
#ajax-preview-content img{max-width:100%}
/* to */
#ajax-preview-content img{max-width:100%;height:auto}

The commit in the repository will follow.

Tschö, Auge

[1]: Assumed you use the default theme in it's default configuration.

--
Trenne niemals Müll, denn er hat nur eine Silbe!

Avatar

Version 2.4.18 - Scaling Images in preview, solved

by Magma, Saturday, January 19, 2019, 00:03 (97 days ago) @ Auge

This fixed it thank you.

2.4.18 seems to be working really good so far.

Avatar

Thumbnail images in Ajax-preview, a test

by Auge ⌂ @, Monday, January 21, 2019, 14:58 (94 days ago) @ Magma

Hello

[image]

Borrowed the image to test the handling of thumbnail images inside the Ajax preview of the default theme.

Tschö, Auge

--
Trenne niemals Müll, denn er hat nur eine Silbe!

Avatar

Thumbnail images in Ajax-preview, a question to Micha

by Auge ⌂ @, Monday, January 21, 2019, 15:02 (94 days ago) @ Auge

Hello

@Micha: Is it intended to make the thumbnail image enlargeable with JS from inside of the Ajax-preview? I would expect this not to work but it does. It's not a bug but a bit surprising for me.

Tschö, Auge

--
Trenne niemals Müll, denn er hat nur eine Silbe!

Avatar

Thumbnail images in Ajax-preview, a question to Micha

by Micha ⌂, Monday, January 21, 2019, 15:09 (94 days ago) @ Auge

Hi Heiko,

@Micha: Is it intended to make the thumbnail image enlargeable with JS from inside of the Ajax-preview?

Well, the JS provides only the container and not the content. Thus, the JS doesn't manage the HTML structure.

/Micha

--
applied-geodesy.org - OpenSource Least-Squares Adjustment Software for Geodetic Sciences

Avatar

Thumbnail images in Ajax-preview, a question to Micha

by Auge ⌂ @, Monday, January 21, 2019, 15:14 (94 days ago) @ Micha

Hello

@Micha: Is it intended to make the thumbnail image enlargeable with JS from inside of the Ajax-preview?


Well, the JS provides only the container and not the content. Thus, the JS doesn't manage the HTML structure.

No problem here.

Tschö, Auge

--
Trenne niemals Müll, denn er hat nur eine Silbe!

RSS Feed of thread
powered by my little forum