Avatar

Problem with marking a post (Bugs)

by Magma @, Friday, August 25, 2017, 10:25 (1158 days ago)

If I mark a posting from the forum index the post marks fine with a red X (although sometimes it doesn't)

If I mark a posting within the thread (for example at the bottom of a page like 2677) I get an error, the red X does not show and is undefined.

Can anyone confirm in the latest release.

Avatar

Problem with marking a post

by Micha ⌂, Friday, August 25, 2017, 10:33 (1158 days ago) @ Magma

Hi,

Can anyone confirm in the latest release.

I cannot confirm this behaviour, Auge, do you can confirm this issue?

/Micha

--
applied-geodesy.org - OpenSource Least-Squares Adjustment Software for Geodetic Sciences

Avatar

Problem with marking a post

by Magma @, Friday, August 25, 2017, 10:40 (1158 days ago) @ Micha

In Opera and Chrome I get this in a thread if I try to mark a post

[image]

Avatar

Problem with marking a post

by Micha ⌂, Friday, August 25, 2017, 12:19 (1158 days ago) @ Magma
edited by Micha, Friday, August 25, 2017, 12:31

Hi,

okay, you are right. Now, I can confirm your problem.

If I mark a posting from the forum index the post marks fine with a red X

Yes, this should always the case.

I get an error, the red X does not show and is undefined.

That is true, because the dynamic JS-file index.php?mode=js_defaults has (sometimes) a wrong user_type-argument.

<script src="{$FORUM_ADDRESS}/index.php?mode=js_defaults&amp;t={$settings.last_changes}{if $user}&amp;user_type={$user_type}{/if}" type="text/javascript" charset="utf-8"></script>

The user_type is set correctly in index.php line 97 but is overwritten in entry.inc.php line 235. Whereas in index.php, the user_type is related to the current user, in entry.inc.php the user_type is related to the user of the posting. :no:

A simple solution is to replace line 32 in main.tmpl by:

<script src="{$FORUM_ADDRESS}/index.php?mode=js_defaults&amp;t={$settings.last_changes}{if $user}&amp;user_type={if $mod}1{elseif $admin}2{else}0{/if}{/if}" type="text/javascript" charset="utf-8"></script>

@Auge, should I update the main.tmpl at Github?

/Micha

--
applied-geodesy.org - OpenSource Least-Squares Adjustment Software for Geodetic Sciences

Avatar

Problem with marking a post

by Auge ⌂ @, Friday, August 25, 2017, 12:47 (1158 days ago) @ Micha

Hello

A simple solution is to replace line 32 in main.tmpl by:

<script src="{$FORUM_ADDRESS}/index.php?mode=js_defaults&amp;t={$settings.last_changes}{if $user}&amp;user_type={if $mod}1{elseif $admin}2{else}0{/if}{/if}" type="text/javascript" charset="utf-8"></script>

@Auge, should I update the main.tmpl at Github?

Indeed, you should.

Tschö, Auge

PS: Wollte schon immer mal "indeed" benutzen. Weiß nicht mal, ob ich es korrekt verwendet habe. :-)

--
Trenne niemals Müll, denn er hat nur eine Silbe!

Avatar

Solved

by Micha ⌂, Friday, August 25, 2017, 15:10 (1158 days ago) @ Auge

Hi,

you should.

Done.

/Micha

--
applied-geodesy.org - OpenSource Least-Squares Adjustment Software for Geodetic Sciences

Avatar

thanks

by Magma @, Saturday, August 26, 2017, 13:30 (1157 days ago) @ Micha

Thanks guys now working.

RSS Feed of thread

powered by my little forum