Post reply

Reply to the message by Auge

Name:

E-mail: (optional, won't be displayed directly)

Leave this field empty:

Homepage: (optional)

Leave this field empty:

Location: (optional)

Remember me (cookie)

Category:

Subject:

Formatting help

skip to input

format text bold: [b]bold text[/b]
format text italic: [i]italic text[/i]
insert hyperlink: [link=http://example.com/]link text[/link] / [link]http://example.com/[/link]
set text color: [color=#rgb]colored text[/color]
font size: [size=small]small text[/size]; [size=large]large text[/size]
insert list: [list][*]list item[/list]
insert image: [img]http://example.com/image.jpg[/img]; left: [img=left]http://example.com/image.jpg[/img]; right: [img=right]http://example.com/image.jpg[/img]; thumbnail: [img=thumbnail]http://example.com/image.jpg[/img]; thumbnail left: [img=thumbnail-left]http://example.com/image.jpg[/img]; thumbnail right: [img=thumbnail-right]http://example.com/image.jpg[/img]
upload image: upload image ...
insert TeX code: [tex]TeX code[/tex]
insert code: [inlinecode]code[/inlinecode]; [code]code[/code]; [code=css]code[/code]; [code=html]code[/code]; [code=javascript]code[/code]; [code=perl]code[/code]; [code=php]code[/code]; [code=sql]code[/code]; [code=xml]code[/code]

:-)
;-)
:-P
:-D
:-|
:-(
:yes:
:no:
:ok:
:lol:
:lol2:
:lol3:
:cool:
:surprised:
:angry:
:crying:
:waving:
:confused:
:lookaround:
:clap:
:love:
:tick:

Message:

> Hello
> 
> > > Am I right, that when I remove the function in the variable [inlinecode]initBackupControls[/inlinecode] and its call inside the function [inlinecode]MyLittleAdmin[/inlinecode] there remains [i]nothing more[/i] than [link=https://github.com/ilosuna/mylittleforum/blob/39a0c3b00be30358aa2c902b9d186e3052ce6f45/js/admin.js#L102]the call for [inlinecode]DragAndDropTable[/inlinecode][/link] in the event listener?
> > 
> > I think this file content can be reduced to
> > 
> > [code=javascript]document.addEventListener("DOMContentLoaded", function(e) {
> > 	new DragAndDropTable(document.getElementById("sortable"), "admin", "action");
> > });[/code]
> 
> That validates my assumption. Thank you.
> 
> > Moreover, the i18n files can be reduced due to the reduction, i.e.,
> > 
> > [code=javascript]lang["delete_backup_confirm"]
> > lang["delete_sel_backup_confirm"]
> > lang["check_all"]
> > lang["uncheck_all"][/code]
> 
> I see, that the strings/variables [inlinecode]lang["check_all"][/inlinecode] and [inlinecode]lang["uncheck_all"][/inlinecode] are only in use along with the backup function. I expected them to be in use in the admin area whereever one can select entries with checkboxes (namely in the lists of users). I would like to keep those strings and use them in the named admin page, but not only there. IMHO the feature to select all displayed entires at once should also be available in the lists of categories, smilies and pages.
> 
> > Do you modify these files?
> 
> Yes I will with the exception of the named strings [inlinecode]lang["check_all"][/inlinecode] and [inlinecode]lang["uncheck_all"][/inlinecode]. IMHO their further use is disputable.
> 
> PS: ist it really necessary to keep a separate JS-ressource for only the one event listener? Why not [link=https://github.com/ilosuna/mylittleforum/blob/39a0c3b00be30358aa2c902b9d186e3052ce6f45/js/main.js#L1503]putting it to main(.min).js[/link] and to separate it from the other functions by adding a class or ID to the body of the admin area and to use that class or ID in an if-statement in the  event handler? Or do you plan to reenhance the separate JS-functions for the admin area?
> 
> Tschö, Auge

E-mail notification on reply of this posting